Will astronomy clubs/societies etc still be relevant and/or growing and why?
Of course they will, as they provide the social avenue to Astronomy. There will always be some people interested in that aspect of the hobby. There will always be those who prefer to talk about it than do it, or talk about it and do it. To some degree though places like Ice In Space already are and will replace clubs/societies.
Will communities like Ice In Space affect the clubs/societies?
Yes, already are I believe (see above).
How do you percieve the threat of light pollution -- will it kill us (metaphorically)?
We will learn to live with it. I expect new technologies will largely negate it's effects for visual and photographic aspects of the hobby.
Will the CCD revolution kill visual observing?
No, rather it will enhance it. I expect there will be a day soon when the average novice doesn't know or care that their "eyepiece" is actually ccd+adaptive optics+realtime image processing+realtime electronic filtering+screen, because it'll be the same size as our eyepieces and have no cords or plugs like our eyepieces, BUT will vastly enhance their view through the telescope. I'm amazed this hasn't already happened and I think is only a matter of time before the components are cheap enough for it to occur.
What will the "kit" of the amateur astronomer be like?
Simplified. Technologies will merge and new ones will arrive, but overall I think the trend in electronics is towards simplification - wireless, amalgamating devices, Don't Make Me Think technologies, etc.
Will the contribution of amateurs to the science of astronomy change and how?
No, stay the same (minor, but present). Our technology will advance, so will the technology of the pro's, and probably always at the same ratio's as current.
Will amateur astronomy only be practiced by the well-heeled or will it diversify further?
This will depend on economic factors. Astronomy for most of us is a hobby, if we didn't have spare cash we wouldn't be doing it. If there's a large economic down turn then the number of people involved will dramatically decrease and only the more well heeled will be able to be actively involved on a regular basis. At the moment, relatively speaking, people have spare cash and have time to do activities other than work to survive, that could very easily reverse.
Will amateurs still be making telescopes/equipment?
Depends on the economic outlook. While we have money to buy equipment we'll do so because it's easier, leaving only a handful of DIY people. If we end up in a situation with less spare money for hobbies, people will revert to DIY, but of course it'll be DIY cooled CCD cameras as well as DIY mirrors.